Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dashes in variants and env variables #1096

Merged
merged 6 commits into from
Oct 9, 2024
Merged

Conversation

wolfv
Copy link
Member

@wolfv wolfv commented Oct 9, 2024

This fixes an issue that came up after adding the variant key / values to the exported environment variables. We did not normalize the variant keys to convert - to _.

Now we are doing that.

I had a few other implementations but they all resulted in large-ish refactors. I think it will be better to refactor the variant discovery once. There are a number of simplifications planned in that core discovery loop anyways.

@wolfv wolfv merged commit c472069 into prefix-dev:main Oct 9, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant