Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect frozen/locked inputs for pixi list #94

Merged
merged 4 commits into from
Apr 11, 2024

Conversation

wpbonelli
Copy link
Contributor

This action runs the following sequnce

  1. pixi install ...
  2. pixi info ...
  3. pixi list ...

Running pixi list without --frozen or --locked will try to update dependencies and lockfile. I think these options need to be passed through to pixi list to keep the environment established by a locked or frozen install from changing.

@pavelzw
Copy link
Collaborator

pavelzw commented Apr 10, 2024

pixi list updating your lockfile shouldn't happen when running with the default settings of setup-pixi, right? Then, by default you are using pixi install --locked and if the lockfile differs, it should crash even before pixi list would be run?

But I can see this being relevant for --frozen (and in general for soundness).

We should add a deprecation warning for pixi<0.14.0 like here:

'pixi list is not supported for pixi versions < `v0.13.0`. Please set `pixi-version` to `v0.13.0` or later.'

@pavelzw pavelzw marked this pull request as ready for review April 11, 2024 00:16
@pavelzw pavelzw self-requested a review as a code owner April 11, 2024 00:16
@pavelzw pavelzw marked this pull request as draft April 11, 2024 00:16
@pavelzw
Copy link
Collaborator

pavelzw commented Apr 11, 2024

oops misclicked

@wpbonelli
Copy link
Contributor Author

pixi list updating your lockfile shouldn't happen when running with the default settings of setup-pixi, right? Then, by default you are using pixi install --locked and if the lockfile differs, it should crash even before pixi list would be run?

But I can see this being relevant for --frozen (and in general for soundness).

Yes --frozen is where I saw this MODFLOW-USGS/modflow6#1713 (comment).

I understand the difference between that and --locked now.

@wpbonelli wpbonelli marked this pull request as ready for review April 11, 2024 00:46
Copy link
Collaborator

@pavelzw pavelzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm
The linter (pnpm lint) is still failing. Can you take care of that?

Also, can you update this test to use 0.14.0?

pixi-url: https://github.com/prefix-dev/pixi/releases/download/v0.13.0/pixi-x86_64-unknown-linux-musl

src/main.ts Outdated Show resolved Hide resolved
@pavelzw pavelzw added the bug Something isn't working label Apr 11, 2024
.github/workflows/test.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@pavelzw pavelzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wpbonelli! I'll release this fix together with #95 later.

@pavelzw pavelzw merged commit 42f9edd into prefix-dev:main Apr 11, 2024
95 of 98 checks passed
@wpbonelli wpbonelli deleted the list branch April 11, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants