Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xcode 9.2 -std=c++17, MACOSX_DEPLOYMENT_TARGET #1003

Closed
wants to merge 2 commits into from
Closed

Xcode 9.2 -std=c++17, MACOSX_DEPLOYMENT_TARGET #1003

wants to merge 2 commits into from

Conversation

joeriedel
Copy link

Xcode 9.2 doesn't work correctly with premake5 generated projects when settings c++17. Also premake wasn't using systemversion() on macosx targets.

@samsinsane
Copy link
Member

Hmm, this is a tricky change. Firstly, given that c++11 isn't supported in earlier versions of XCode but c++0x is, I have a feeling that this is a very similar situation - perhaps it's time to start making new actions for XCode for these breaking changes? Secondly, you'll need to update the unit tests and add unit tests for systemversion. In the future, it would be better if these unrelated changes were split into their own PRs, while your C++17 changes are potentially contentious, your systemversion changes are not and are just going to be held up while we discuss what to do with C++ support in XCode.

@pdoane
Copy link

pdoane commented Feb 13, 2018 •
edited
Loading

There are similar discussions going on for the Visual Studio side. I think the best answer here is that 'c++11' only maps to a compiler that claims full compliance and not to 'c++0x', so this seems like a change in the right direction but it needs to be done universally. Additional options for 'c++0x' would make sense as well.

@samsinsane samsinsane mentioned this pull request Jul 19, 2018
Closed
@samsinsane samsinsane mentioned this pull request Sep 22, 2019
Closed
baconpaul added a commit to baconpaul/premake-core that referenced this pull request Sep 22, 2019
@baconpaul
On OSX, convert systemversion to MACOSX_DEPLOYMENT_TARGET
73805ea 
Per the discussion in issue premake#1336, if systemversion is set
output MACOSX_DEPLOYMENT_TARGET into the resulting xcode project.
This borrows a diff from the (unmerged) PR premake#1003, applies it
in isolation, and adds a pair of unit tests to confirm that both
setting and not setting the systemversion results in correct
output.

Closes premake#1336
@baconpaul baconpaul mentioned this pull request Sep 22, 2019
Merged
@starkos
Copy link
Member

starkos commented Oct 14, 2019

Seeing as the systemversion() change has already been merged by #1337, I'm going to go ahead and close this one. I agree with @pdoane that this fits into the large discussion for handing the "fluid" toolset releases we're seeing these days.

@starkos starkos closed this Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joeriedel @samsinsane @pdoane @starkos