Fix curl compilation on Debian PowerPC. #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, __ppc__ is not defined by GCC, but __PPC__ is.
|
I feel like this patch should probably be submit against CURL... |
|
CURL upstream seems to check for |
|
can we just take the fix from curl then? |
|
I guess, but if you do, please pay attention that the PR I linked to caused a regression, so their correct fix is actually two commits. Also my fix includes a blind fix for PPC64, and theirs doesn't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, ppc is not defined by GCC, but PPC is.