Support for CSDialect #1142
Merged
Support for CSDialect #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsinsane
approved these changes
Jul 29, 2018
| @@ -687,7 +687,6 @@ | |||
| end | |||
| end | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
I'm fairly certain that there's normally two lines between functions. This also applies to the new lines below for dotnetbase.csversion.
| @@ -590,6 +590,12 @@ | |||
| kind = "string", | |||
| } | |||
|
|
|||
| api.register { | |||
| name = "csversion", | |||
There was a problem hiding this comment.
These are supposed to be in alphabetical order, I think dotnetframework was renamed from framework which is why it's here and not up with the other d* APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Evilsmevil This is your great work in the wild...