Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved test runner usage #1352

Merged
merged 1 commit into from
Oct 13, 2019
Merged

Conversation

samsinsane
Copy link
Member

What does this PR do?

This PR extends the test runner to allow for some of the discussed items in #1114; wildcard support and specifying tests without using --test-only.

How does this PR change Premake's behavior?

This shouldn't break the old functionality, but does extend it as mentioned above.

Anything else we should know?

I wrote this several months before the commit date suggests, so I'm not sure where I got up to with it but it does seem to work. Some of the changes might be for the comma separated list, but I couldn't see anything to suggest I added support for that and it didn't work when tested.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

modules/self-test/self-test.lua Outdated Show resolved Hide resolved
@starkos
Copy link
Member

starkos commented Oct 13, 2019

Quick question inline…

@starkos starkos merged commit b02c495 into premake:master Oct 13, 2019
@samsinsane samsinsane deleted the ssurtees/testImprovement branch November 6, 2019 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants