Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shaderincludedirs to fxcompile configuration #1355

Merged
merged 1 commit into from
Oct 21, 2019

Conversation

starkos
Copy link
Member

@starkos starkos commented Oct 20, 2019

What does this PR do?

Finishes up PR #1259. The original description is "Added shaderincludedirs to the visual studio configuration for fxcompile. Kept name inline with the premake includedirs."

Changed the field type to "list:directory" to match includedirs.

How does this PR change Premake's behavior?

Just adds a new API. No changes otherwise.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

@samsinsane samsinsane merged commit 0987dcd into premake:master Oct 21, 2019
@starkos starkos deleted the shaderincludedirs2 branch March 16, 2020 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants