Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add table.tostring #15

Merged
merged 1 commit into from
Apr 8, 2015
Merged

add table.tostring #15

merged 1 commit into from
Apr 8, 2015

Conversation

tvandijck
Copy link
Contributor

No description provided.

@TurkeyMan
Copy link
Contributor

I've wanted this for ages. It seems like a big implementation though. Is this particularly different/better than the seemingly standard 'tprint' function that's plastered all over the net?
I'm sure you Bliz guys know lua better than anyone ;)

@tvandijck
Copy link
Contributor Author

I don't think we know lua all that well ;) at least not me... so some of these things just come from the need to display something, and it seems useful to add... the tprint looks simpler, and I'm not sure if it prints things the same way, but either one could work I guess... we can always modify it to get the thing out of it that we need.

@tvandijck
Copy link
Contributor Author

Oh, and actually looking at tprint... that really just prints things... table.tostring returns a string... we save that to a log sometimes... I'm sure we can modify tprint to return a string, although I have no idea what send does... also the 'tostring' method doesn't always return something useful, primarily for values.

@TurkeyMan
Copy link
Contributor

I'm sure it's fine. It was just at a cursory glance I found it harder to digest, and didn't immediately see any significant difference in functionality.

add table.tostring
1a880e5 
Conflicts:
	src/base/table.lua
starkos added a commit that referenced this pull request Apr 8, 2015
@starkos
Merge pull request #15 from Blizzard/pr9
b27005d 
add table.tostring
@starkos starkos merged commit b27005d into premake:master Apr 8, 2015
@tvandijck tvandijck deleted the pr9 branch May 11, 2015 17:08
TurkeyMan pushed a commit to Blizzard/premake-core that referenced this pull request Jun 4, 2018
@bwhittle @TurkeyMan
misc android fixes (premake#15)
6b585d6 
* fixed exception handling and rtti 'Off' setting
ignored warnings now auto generated additional build params as such
added support for pch (which need to take a relative path from cwd)
instead of a file located via the search path.

* added unit test for android pch
TurkeyMan pushed a commit to Blizzard/premake-core that referenced this pull request Jun 5, 2018
@bwhittle @TurkeyMan
misc android fixes (premake#15)
9801a5f 
* fixed exception handling and rtti 'Off' setting
ignored warnings now auto generated additional build params as such
added support for pch (which need to take a relative path from cwd)
instead of a file located via the search path.

* added unit test for android pch
TurkeyMan pushed a commit to Blizzard/premake-core that referenced this pull request Dec 5, 2018
@bwhittle @TurkeyMan
misc android fixes (premake#15)
b63387e 
* fixed exception handling and rtti 'Off' setting
ignored warnings now auto generated additional build params as such
added support for pch (which need to take a relative path from cwd)
instead of a file located via the search path.

* added unit test for android pch
TurkeyMan pushed a commit to Blizzard/premake-core that referenced this pull request Dec 5, 2018
@bwhittle @TurkeyMan
misc android fixes (premake#15)
d916109 
* fixed exception handling and rtti 'Off' setting
ignored warnings now auto generated additional build params as such
added support for pch (which need to take a relative path from cwd)
instead of a file located via the search path.

* added unit test for android pch
TurkeyMan pushed a commit to Blizzard/premake-core that referenced this pull request Dec 8, 2018
@bwhittle @TurkeyMan
misc android fixes (premake#15)
3e29aee 
* fixed exception handling and rtti 'Off' setting
ignored warnings now auto generated additional build params as such
added support for pch (which need to take a relative path from cwd)
instead of a file located via the search path.

* added unit test for android pch
TurkeyMan pushed a commit to Blizzard/premake-core that referenced this pull request Jan 17, 2019
@bwhittle @TurkeyMan
misc android fixes (premake#15)
2648ade 
* fixed exception handling and rtti 'Off' setting
ignored warnings now auto generated additional build params as such
added support for pch (which need to take a relative path from cwd)
instead of a file located via the search path.

* added unit test for android pch
vadz added a commit to vadz/premake-core that referenced this pull request Aug 27, 2023
@vadz
Fix crash when enabling debugger under Linux
e739d88 
Rename buffer_init() to avoid clashing with a function with the same
name in luasocket code: under Linux, due to the of "flat" ELF
namespaces, when luasocket shared library is loaded into premake process
the existing premake function is used instead of the function defined in
luasocket code, resulting in luasocket buffer not being properly
initialized which, in turn, leads to mysterious crashes as soon as it's
used, e.g. dereferencing null timeout field:

	(gdb) bt
	#0  0x00007ffff7cce642 in timeout_markstart (tm=0x0) at ../../binmodules/luasocket/src/timeout.c:116
	premake#1  0x00007ffff7cc7618 in buffer_meth_receive (L=0x5555557882a8, buf=0x5555559044a0) at ../../binmodules/luasocket/src/buffer.c:113
	premake#2  0x00007ffff7ccd545 in meth_receive (L=0x5555557882a8) at ../../binmodules/luasocket/src/tcp.c:135
	premake#3  0x000055555558c1cc in luaD_precall (L=0x5555557882a8, func=0x5555558e36b0, nresults=1) at ../../contrib/lua/src/ldo.c:434
	premake#4  0x00005555555a971f in luaV_execute (L=0x5555557882a8) at ../../contrib/lua/src/lvm.c:1134
	premake#5  0x000055555558c555 in luaD_call (L=0x5555557882a8, func=0x5555558e3640, nResults=0) at ../../contrib/lua/src/ldo.c:499
	premake#6  0x000055555558c5b3 in luaD_callnoyield (L=0x5555557882a8, func=0x5555558e3640, nResults=0) at ../../contrib/lua/src/ldo.c:509
	premake#7  0x0000555555588af5 in lua_callk (L=0x5555557882a8, nargs=2, nresults=0, ctx=0, k=0x0) at ../../contrib/lua/src/lapi.c:925
	premake#8  0x00005555555af4f2 in hookf (L=0x5555557882a8, ar=0x7fffffffd270) at ../../contrib/lua/src/ldblib.c:316
	premake#9  0x000055555558bafb in luaD_hook (L=0x5555557882a8, event=2, line=273) at ../../contrib/lua/src/ldo.c:269
	premake#10 0x000055555558b284 in luaG_traceexec (L=0x5555557882a8) at ../../contrib/lua/src/ldebug.c:687
	premake#11 0x00005555555a6b71 in luaV_execute (L=0x5555557882a8) at ../../contrib/lua/src/lvm.c:801
	premake#12 0x000055555558c555 in luaD_call (L=0x5555557882a8, func=0x555555889360, nResults=1) at ../../contrib/lua/src/ldo.c:499
	premake#13 0x000055555558c5b3 in luaD_callnoyield (L=0x5555557882a8, func=0x555555889360, nResults=1) at ../../contrib/lua/src/ldo.c:509
	premake#14 0x0000555555588b60 in f_call (L=0x5555557882a8, ud=0x7fffffffdbb0) at ../../contrib/lua/src/lapi.c:943
	premake#15 0x000055555558b5a5 in luaD_rawrunprotected (L=0x5555557882a8, f=0x555555588b2b <f_call>, ud=0x7fffffffdbb0)
	    at ../../contrib/lua/src/ldo.c:142
	premake#16 0x000055555558cd85 in luaD_pcall (L=0x5555557882a8, func=0x555555588b2b <f_call>, u=0x7fffffffdbb0, old_top=64, ef=48)
	    at ../../contrib/lua/src/ldo.c:729
	premake#17 0x0000555555588c28 in lua_pcallk (L=0x5555557882a8, nargs=0, nresults=1, errfunc=3, ctx=0, k=0x0)
	    at ../../contrib/lua/src/lapi.c:969
	premake#18 0x0000555555584734 in premake_pcall (L=0x5555557882a8, nargs=0, nresults=1) at ../../src/host/premake.c:287
	premake#19 0x0000555555584867 in premake_execute (L=0x5555557882a8, argc=5, argv=0x7fffffffdd98,
	    script=0x555555685052 "src/_premake_main.lua") at ../../src/host/premake.c:316
	premake#20 0x000055555558535e in main (argc=5, argv=0x7fffffffdd98) at ../../src/host/premake_main.c:19

For consistency, rename all the other buffer_xxx functions too, even
though they don't conflict with anything right now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tvandijck @TurkeyMan @starkos