Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Ability to Disable JMC in Visual Studio #1534

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

nickclark2016
Copy link
Member

What does this PR do?

This PR resolves #1526. It adds a "jmc" option to projects in order to disable just my code debugging.

Usage:

project "SomeProject"
   justmycode "Off"

How does this PR change Premake's behavior?

There is no change for preexisting projects, thus it is a non-breaking change. By settings justmycode to "Off" in a VS2017 or newer project, it adds a flag to the project file to disable JMC.

Anything else we should know?

N/A

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits

Copy link
Member

@starkos starkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, and all the help you've been providing lately—much appreciated!

@starkos starkos merged commit c6580ff into premake:master Oct 16, 2020
@nickclark2016
Copy link
Member Author

nickclark2016 commented Oct 17, 2020

Just to follow up on this, can we get a justmycode page in the wiki? And no problem! I try to contribute back changes that I've used in my own projects as well as help pick up some of the low hanging fruit.

@smbradley
Copy link

Shouldn't this be a boolean? It seems kind of weird to be able to set it to Off but not to On

@nickclark2016 nickclark2016 deleted the issues/1526 branch June 24, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need support for Just My Code in VS2017
3 participants