Fix D module compiler output for visual studio #1658
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes the output for the D compiler. In Visual Studio, this forces a compiler to be set in the project file.
The problem was that the toolset for D projects was always being set to "msc-v142" for Visual Studio 2019 (did not check the value for previous versions of VS). If the toolset was defined in the premake script, it was not an allowed value. The only way for this to work previously was by using
--dc=dmd
(change dmd to your preferred D compiler).How does this PR change Premake's behavior?
There are no breaking changes. All changes are to fix the "D" module (and allow for other module support). Premake now supports the "dmd", "gdc", and "ldc" toolset options for D projects. This was done by adding them to the allowed values in the "toolset" premake field.
Usage:
| Module / Toolset | Old Output | New Output |
| --- | --- |
| VS 2019 / dmd | | 0 |
| VS 2019 / gdc | | 1 |
| VS 2019 / ldc | | 2 |
Anything else we should know?
Closes #1603
So what next? The gmake module still needs work to actually function. When running with "gmake" on the command line, it still attempts to go through the C++ module instead of the D module. In order to minimize the number of changes in the review, I will leave that for another day.
Did you check all the boxes?
closes #XXXX
in comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!