Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Visual Studio Version to 17 so sln is opened with VS2022 #1737

Merged
merged 3 commits into from
Nov 1, 2021
Merged

Change Visual Studio Version to 17 so sln is opened with VS2022 #1737

merged 3 commits into from
Nov 1, 2021

Conversation

simco50
Copy link
Contributor

@simco50 simco50 commented Oct 26, 2021

What does this PR do?

Change the VS version from 16 to 17 so to correctly match what VS2022 solutions look like.

How does this PR change Premake's behavior?

None

Anything else we should know?

None

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

@simco50
Copy link
Contributor Author

simco50 commented Oct 27, 2021

I'm not sure if this requires any unit tests?
Apologies as I'm not very familiar with the process.

@nickclark2016
Copy link
Member

I'm the unit test police. Yeah, if you could add a test here, that'd be great!

https://github.com/premake/premake-core/blob/master/modules/vstudio/tests/sln2005/test_header.lua

Copy link
Member

@nickclark2016 nickclark2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until unit test is added.

@starkos starkos merged commit 12bc2ea into premake:master Nov 1, 2021
@simco50 simco50 deleted the vs2022_version branch November 1, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants