Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added API for CompileAsWinRT #1747

Merged
merged 1 commit into from
Nov 26, 2021

Conversation

samsinsane
Copy link
Member

What does this PR do?

Adds API to consume the Windows Runtime language extensions.

How does this PR change Premake's behavior?

No breaking changes, only adds the element when the API is set.

Anything else we should know?

N/A

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

Copy link
Member

@starkos starkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why consumewinrtextension "On" and not just winrt "On"?

@samsinsane
Copy link
Member Author

Why consumewinrtextension "On" and not just winrt "On"?

I would find it kind of confusing if it was winrt instead of consumewinrtextension. This enables the usage of C++/CX, but Microsoft also released C++/WinRT which doesn't require this to be enabled - nice and confusing! The UI item this PR implements is labelled as "Consume Windows Runtime Extension". I'm happy to change it but I feel like "WinRT" means too many things for an API to be named just winrt.


### Parameters ###

`value` one of:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`value` one of:
`value` is one of:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had literally one job in my review and I failed 😅

@samsinsane samsinsane force-pushed the ssurtees/consumewinrtextension branch from 49c75cd to 12ca8f4 Compare November 8, 2021 15:49
@starkos starkos merged commit a817170 into premake:master Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants