-
-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added API for CompileAsWinRT #1747
Added API for CompileAsWinRT #1747
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why consumewinrtextension "On"
and not just winrt "On"
?
I would find it kind of confusing if it was |
|
||
### Parameters ### | ||
|
||
`value` one of: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`value` one of: | |
`value` is one of: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had literally one job in my review and I failed 😅
49c75cd
to
12ca8f4
Compare
What does this PR do?
Adds API to consume the Windows Runtime language extensions.
How does this PR change Premake's behavior?
No breaking changes, only adds the element when the API is set.
Anything else we should know?
N/A
Did you check all the boxes?
closes #XXXX
in comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!