Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation for static and shared linking suffixes #1826

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

nickclark2016
Copy link
Member

What does this PR do?

Documentation update to include :static and :shared suffixes.

How does this PR change Premake's behavior?

N/A

Anything else we should know?

Closes #1818

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

@nickclark2016 nickclark2016 requested review from starkos, samsinsane and KyrietS and removed request for KyrietS February 24, 2022 16:34
Copy link
Member

@KyrietS KyrietS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for this! 🤠👍

@KyrietS
Copy link
Member

KyrietS commented Mar 29, 2022

Can you rebase your branch so I can finally merge it?
I thought somone else would click the merge button after my approval but it didn't happen and your branch is out-of-date now. Sorry 😅

@nickclark2016
Copy link
Member Author

Please ignore my git issues. Couldn't get my branch to rebase cleanly.

@KyrietS KyrietS merged commit 5b69a55 into premake:master Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

:static and :shared specifiers for links are not documented
2 participants