Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AntTarget to vsandroid project file #1992

Merged
merged 1 commit into from
Apr 15, 2023
Merged

Conversation

0x416c69
Copy link
Contributor

@0x416c69 0x416c69 commented Oct 25, 2022

What does this PR do?

Adds AntTarget to .androidproj files

How does this PR change Premake's behavior?

All the android builds used to be built targeting the debug mode, which adds android:debuggable=true, generates a different BuildConfig.java (Debug=true), etc.
This is unacceptable for release builds.

Anything else we should know?

I'm not sure when did VS add this option but I don't think adding this on older VS versions would hurt anything.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass (There are no tests on AndroidAppLibName or many other elements on the android module and I don't know how to implement them)
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

Copy link
Member

@nickclark2016 nickclark2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a corresponding unit test?

@0x416c69
Copy link
Contributor Author

0x416c69 commented Nov 1, 2022

Unfortunately I don't know how, if there is a unit test for the "AndroidAppLibName" element which is already in there I could follow suit but I cannot find it...?

Copy link
Member

@samsinsane samsinsane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge this since we don't have unit tests for a lot of the Android module currently.

@samsinsane samsinsane merged commit 18d8fd7 into premake:master Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants