Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to minimize differences after Codelite re-save the file #2032

Merged
merged 1 commit into from
Apr 15, 2023

Conversation

Jarod42
Copy link
Contributor

@Jarod42 Jarod42 commented Feb 6, 2023

What does this PR do?

Change to minimize differences after Codelite re-save the file

  • Version in header
  • indentation of VirtualDirectory node
  • order of pch and linker attributes
  • order of custom build nodes
  • Handle empty nodes (add PreBuild/PostNuild, remove Plugins)
  • Add EOL at EOF.

How does this PR change Premake's behavior?

No behavior changes.

Anything else we should know?

No.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

@Jarod42
Copy link
Contributor Author

Jarod42 commented Feb 6, 2023

[ FAILED ] premake_http.http_get
HTTP response code said error
The requested URL returned error: 502 Bad Gateway

random connection error:
Unrelated to my changes.

Fixing that UT would probably be my next PR :-)

Edit:
-> (as promise: #2034)

- Version in header
- indentation of VirtualDirectory node
- order of pch and linker attributes
- order of custom build nodes
- Handle empty nodes (add PreBuild/PostNuild, remove Plugins)
- Add EOL at EOF
- Add '<BuildSystem Name="Default"/>'
@samsinsane samsinsane merged commit e1979af into premake:master Apr 15, 2023
@Jarod42 Jarod42 deleted the Codelite_Indentation branch April 15, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants