Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nil indexing for codelite #2088

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

Jarod42
Copy link
Contributor

@Jarod42 Jarod42 commented May 22, 2023

What does this PR do?

Fix "attempt to index a nil value".
It happens with https://github.com/Jarod42/premake-sample-projects/projects-qt/project-qt with objdir removed.

How does this PR change Premake's behavior?

Just Codelite generator.

Anything else we should know?

No.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

Copy link
Member

@nickclark2016 nickclark2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickclark2016 nickclark2016 merged commit 26725da into premake:master Jul 14, 2023
@Jarod42 Jarod42 deleted the codelite_indexing_nil branch July 14, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants