[vs*] Allow to have per-file cdialect/cppdialect.
#2194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarod42
commented
Mar 21, 2024
| @@ -1485,7 +1487,7 @@ | |||
|
|
|||
| local contents = p.capture(function () | |||
| p.push() | |||
| p.callArray(fileFunc, cfg, file) | |||
| p.callArray(fileFunc, nil, file) | |||
There was a problem hiding this comment.
There are no cfg here, so it is actually nil.
samsinsane
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Handle
cdialect/cppdialectin per-file configuration for visual studio generatorsHow does this PR change Premake's behavior?
Only affect visual studio generators
Anything else we should know?
cppdialecttested with dedicated project https://github.com/Jarod42/premake-sample-projects/actions/runs/8377114412Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)