Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document os.rename and os.getenv APIs #2252

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

tritao
Copy link
Contributor

@tritao tritao commented Sep 19, 2024

What does this PR do?

Documents the os.rename and os.getenv APIs

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

@tritao tritao marked this pull request as ready for review September 19, 2024 19:20
website/docs/os.getenv.md Outdated Show resolved Hide resolved
website/docs/os.rename.md Show resolved Hide resolved
website/docs/os.rename.md Show resolved Hide resolved
website/sidebars.js Outdated Show resolved Hide resolved
@tritao
Copy link
Contributor Author

tritao commented Sep 21, 2024

Updated the PR with requested fixes.

Copy link
Member

@samsinsane samsinsane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to approve and merge this, though I'm not sure I agree with documenting Lua APIs like this, but I do agree we should have something for them.

@samsinsane samsinsane merged commit 3f3c358 into premake:master Sep 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants