Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent empty arrays as expected values for test.contains and test.excludes #2278

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

samsinsane
Copy link
Member

  • Fixed GCC tests that used empty arrays

What does this PR do?

Prevents misuse of test.contains and test.excludes and fixes the GCC tests that misused them.

How does this PR change Premake's behavior?

N/A

Anything else we should know?

N/A

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

…cludes

- Fixed GCC tests that used empty arrays
@samsinsane samsinsane merged commit 4cbd316 into premake:master Oct 2, 2024
12 checks passed
@samsinsane samsinsane deleted the ssurtees/testFix branch October 2, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants