Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap improvements #2290

Closed
wants to merge 1 commit into from
Closed

Conversation

tritao
Copy link
Contributor

@tritao tritao commented Oct 10, 2024

What does this PR do?

Adds a new Bootstrap.sh script to simplify bootstrap in non-Windows platforms.
Re-uses all the bootstrap scripts for CI to make sure they are well tested.

How does this PR change Premake's behavior?

I updated CI to use vs2022 as MSDEV. Previously we were using vs2019, however if you pass that to Bootstrap.bat then vswhere.exe cannot find VS.

AFACT there is no point in forcing Premake to generate vs2019 files to build with MSVC 2022.

So either we just pass an empty value so it auto detects latest MSVC, or pass it explicitly as part of a matrix as I've done.

@tritao tritao force-pushed the bootstrap-improv branch 12 times, most recently from c3ab48e to ddf06a6 Compare October 10, 2024 13:39
@tritao tritao marked this pull request as ready for review October 10, 2024 14:04
@tritao tritao closed this Oct 10, 2024
@tritao tritao reopened this Oct 10, 2024
@tritao tritao closed this Oct 10, 2024
@tritao
Copy link
Contributor Author

tritao commented Oct 10, 2024

Re-opening a new one due to CI status report getting bugged due to adding a new matrix on a force push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants