Increase Lua's debug path size. #2298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Lua reports a stack traceback, it prints the path to the files.
But by default, right now, it's limited to 60 characters, which gets
super annoying when trying to work on the codebase, as paths are
ellipsized if they are bigger, which prevents from Ctrl-clicking on them
to go to the right location in the IDE/editor.
This increases the limit to double the default size, which so far has
worked fine for me.
Before:
```
stack traceback:
.../premake/modules/gmake/tests/cpp/test_make_pch.lua:66:
```
After:
```
stack traceback:
/home/joao/dev/tools/premake/modules/gmake/tests/cpp/test_make_pch.lua:66:
```
tritao
force-pushed
the
increase-lua-path-limit
branch
from
5aaf25a
to
8636bbf
Compare
nickclark2016
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When Lua reports a stack traceback, it prints the path to the files.
But by default, right now, it's limited to 60 characters, which gets super annoying when trying to work on the codebase, as paths are ellipsized if they are bigger, which prevents from Ctrl-clicking on them to go to the right location in the IDE/editor.
This increases the limit to double the default size, which so far has worked fine for me.
Before:
After:
How does this PR change Premake's behavior?
Nicer path outputs for errors.
Anything else we should know?
It changes Lua's
luaconf.h. Unfortunately I don't think there is any other way since the original header does not check if the value is already defined, so even if we define it ourselves inpremake5.lua, the value is overriden by the default one, with some warnings to boot.So change it in the conf file, which contains a section for local modifications anyway.