Add MSBuild target to Bootstrap.mak #639
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I mentioned a while ago, Bootstrap.mak will not directly work when no full VS install is present.
This attempts to resolve said issue by adding a separate target (
windows-msbuild
) to the Makefile.Another solution would be to handle upgrade behavior based on the MSDEV variable and use
msbuild
to build in all cases, but this would break (or require conditions, and I'm not too sure how well cross-platform Makefiles like those) for VS2008< which use VCBuild project files rather than the VS2010+ MSBuild .vcxproj w/ toolset configuration, and might potentially cause different behavior for build processes relying on the currentwindows
target.For VS2010+, there is no functional difference between binaries built by either method (except not specifying an explicit MSDEV argument will default to
v110
due to the vs2012 toolchain setting - and these will not be upgraded) asdevenv /Build
will dispatch to MSBuild for these projects anyway (though handling solution parsing internally, rather than using MSBuild compatibility behavior).