Generated project files are now correctly located beside script

[samsinsane]

Fixes #371

[starkos]

I'm trying to remember the conversations that we had around this. I think the behavior we were trying to implement is that if location were set on the workspace, this value would be inherited by the projects, like any other configuration value. I'm not 100% sure if we have a test for that or not?

workspace "MyWorkspace"
  location "build"

project "MyProject"
  -- implicit location is "build", inherited from MyWorkspace

So if a location is set on the workspace, it should be inherited by the project. But if no location is set, then project should use its basedir.

[samsinsane]

This PR appears to do that.

Using Premake as the test.
Without this PR:

Premake5.sln
Premake5.vcxproj
lua-lib.vcxproj

With this PR:

Premake5.sln
Premake5.vcxproj
contrib/lua/lua-lib.vcxproj

With this PR and --to=testing: (which only applies to the workspace)

testing/Premake5.sln
testing/Premake5.vcxproj
testing/lua-lib.vcxproj

I'm happy to add tests in for this kind of thing, but I'm not sure exactly how to test it?

wks = test.createWorkspace()
origin = os.getcwd()
os.setcwd(origin + "/folder")
prj = test.createproject(wks)
os.setcwd(origin)

test.issame(origin, wks.location)
test.issame(origin + "/folder", prj.location)

This seems like too much of a hack?

[starkos]

I'm happy to add tests in for this kind of thing, but I'm not sure exactly how to test it?

I'm probably wasn't either, which is probably why there aren't tests for it :) What about…?

wks = test.createWorkspace()
wks.basedir = os.getcwd()

prj = test.createproject(wks)
prj.basedir = path.join(os.getcwd(), "folder")

Going to approve this anyway, since you've confirmed we're getting the behavior we want for both cases.

[tritao]

Just had to workaround this issue today... thanks for the fix @samsinsane.