Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes translateCommandsAndPaths, and debugargs. #926

Merged
merged 1 commit into from
Nov 30, 2017

Conversation

tvandijck
Copy link
Contributor

No description provided.

Copy link
Member

@samsinsane samsinsane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, perhaps we should have tests for os.translateCommandAndPath that work on each of the predefined maps?

premake5.lua Outdated
@@ -155,8 +155,8 @@

filter "configurations:Debug"
targetdir "bin/debug"
debugargs { "--scripts=%{prj.location}/%{path.getrelative(prj.location, prj.basedir)} test"}
debugdir "%{path.getrelative(prj.location, prj.basedir)}"
debugargs { "--scripts=.", "test" }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this line is correct yet...

@tvandijck tvandijck force-pushed the translateCommandsAndPaths-fixes branch from 0423e9a to ccc6e10 Compare November 30, 2017 17:24
@tvandijck tvandijck force-pushed the translateCommandsAndPaths-fixes branch from ccc6e10 to bf4c71e Compare November 30, 2017 17:25
@tvandijck tvandijck merged commit 5a0b07c into premake:master Nov 30, 2017
@tvandijck tvandijck deleted the translateCommandsAndPaths-fixes branch November 30, 2017 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants