-
-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3.0.0-alpha.15 #744
Merged
Merged
v3.0.0-alpha.15 #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…preserve - #734 * fix(core): revert peer dependecy to 16.3.0 ([new context api](https://github.com/facebook/react/blob/master/CHANGELOG.md#1630-march-29-2018)) since only hooks require 16.8.0
fix(types): switch typeof Firebase to any (prevents issue with passing some version of Firebase JS SDK)
Codecov Report
@@ Coverage Diff @@
## next #744 +/- ##
==========================================
+ Coverage 82.86% 87.03% +4.16%
==========================================
Files 30 30
Lines 969 972 +3
Branches 177 178 +1
==========================================
+ Hits 803 846 +43
+ Misses 166 126 -40 |
…WithFirestore * fix(tests): remove old tests for createUseFirestore and createUseFirebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
createUseFirestore
,createWithFirestore
,createUseFirebase
,createWithFirebase
) since store selection is not necessarytypeof Firebase
toany
(prevents issue with passing some version of Firebase JS SDK)Check List
If not relevant to pull request, check off as complete
Relevant Issues