fix: move series in front of xy gridlines (apache-superset#119)

preset-io · Jun 5, 2019 · 32850ef · 32850ef
1 parent 3269c7c
commit 32850ef
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/BoxPlot/BoxPlot.tsx b/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/BoxPlot/BoxPlot.tsx
@@ -120,9 +120,9 @@ export default class BoxPlot extends React.PureComponent<Props> {
         xScale={convertScaleToDataUIScale(channels.x.scale!.config)}
         yScale={convertScaleToDataUIScale(channels.y.scale!.config)}
       >
-        {children}
         {layout.renderXAxis()}
         {layout.renderYAxis()}
+        {children}
       </XYChart>
     ));
   }

diff --git a/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/Line.tsx b/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/Line.tsx
@@ -259,9 +259,9 @@ export default class LineChart extends PureComponent<Props> {
             xScale={convertScaleToDataUIScale(channels.x.scale!.config)}
             yScale={convertScaleToDataUIScale(channels.y.scale!.config)}
           >
-            {children}
             {layout.renderXAxis()}
             {layout.renderYAxis()}
+            {children}
             <CrossHair
               fullHeight
               strokeDasharray=""

diff --git a/.../superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/ScatterPlot/ScatterPlot.tsx b/.../superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/ScatterPlot/ScatterPlot.tsx
@@ -135,9 +135,9 @@ export default class ScatterPlot extends PureComponent<Props> {
         xScale={convertScaleToDataUIScale(channels.x.scale!.config)}
         yScale={convertScaleToDataUIScale(channels.y.scale!.config)}
       >
-        {children}
         {layout.renderXAxis()}
         {layout.renderYAxis()}
+        {children}
       </XYChart>
     ));
   }