Skip to content

Commit

Permalink
fix: improve performance on reports log queries (apache#26416)
Browse files Browse the repository at this point in the history
  • Loading branch information
dpgaspar authored Jan 15, 2024
1 parent c947be3 commit 2f3bb5b
Show file tree
Hide file tree
Showing 3 changed files with 76 additions and 0 deletions.
2 changes: 2 additions & 0 deletions UPDATING.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ assists people when migrating to a new version.

### Potential Downtime

- [26416](https://github.com/apache/superset/pull/26416): adds 2 database indexes to report_execution_log and 1 to report_recipient to improve performance, this may cause downtime on large deployments.

### Other

- [24982](https://github.com/apache/superset/pull/24982): By default, physical datasets on Oracle-like dialects like Snowflake will now use denormalized column names. However, existing datasets won't be affected. To change this behavior, the "Advanced" section on the dataset modal has a "Normalize column names" flag which can be changed to change this behavior.
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
"""add indexes to report models
Revision ID: 65a167d4c62e
Revises: 06dd9ff00fe8
Create Date: 2024-01-05 16:20:31.598995
"""

# revision identifiers, used by Alembic.
revision = "65a167d4c62e"
down_revision = "06dd9ff00fe8"

import sqlalchemy as sa
from alembic import op
from sqlalchemy.dialects import postgresql


def upgrade():
op.create_index(
"ix_report_execution_log_report_schedule_id",
"report_execution_log",
["report_schedule_id"],
unique=False,
)
op.create_index(
"ix_report_execution_log_start_dttm",
"report_execution_log",
["start_dttm"],
unique=False,
)
op.create_index(
"ix_report_recipient_report_schedule_id",
"report_recipient",
["report_schedule_id"],
unique=False,
)


def downgrade():
op.drop_index(
"ix_report_recipient_report_schedule_id", table_name="report_recipient"
)
op.drop_index(
"ix_report_execution_log_start_dttm", table_name="report_execution_log"
)
op.drop_index(
"ix_report_execution_log_report_schedule_id", table_name="report_execution_log"
)
10 changes: 10 additions & 0 deletions superset/reports/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
DateTime,
Float,
ForeignKey,
Index,
Integer,
String,
Table,
Expand Down Expand Up @@ -196,6 +197,10 @@ class ReportRecipients(Model, AuditMixinNullable):
foreign_keys=[report_schedule_id],
)

__table_args__ = (
Index("ix_report_recipient_report_schedule_id", report_schedule_id),
)


class ReportExecutionLog(Model): # pylint: disable=too-few-public-methods

Expand Down Expand Up @@ -228,3 +233,8 @@ class ReportExecutionLog(Model): # pylint: disable=too-few-public-methods
backref=backref("logs", cascade="all,delete,delete-orphan"),
foreign_keys=[report_schedule_id],
)

__table_args__ = (
Index("ix_report_execution_log_report_schedule_id", report_schedule_id),
Index("ix_report_execution_log_start_dttm", start_dttm),
)

0 comments on commit 2f3bb5b

Please sign in to comment.