[WIP] Adding support for case sensitive table names #12071
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praveen2112
changed the title
|
FYI: @findepi |
Praveen2112
force-pushed
the
case_sensitive_table_names
branch
3 times, most recently
from
2255426
to
8a3b5ce
Compare
Praveen2112
force-pushed
the
case_sensitive_table_names
branch
3 times, most recently
from
5d168a9
to
bf4d471
Compare
added 5 commits
December 18, 2018 22:08
Praveen2112
force-pushed
the
case_sensitive_table_names
branch
from
bf4d471
to
6534b38
Compare
Praveen2112
force-pushed
the
case_sensitive_table_names
branch
from
6534b38
to
52e0789
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in Progress.
Currently Presto doesn't have support for case-sensitive table names (#2863). Here we try to add support for the same by passing the actual schema/table name which is obtained from
QualifiedNamewhere we maintain both the actual table/schema name and also the transformed one(transformed to lower case). We just need to pass it to the connector overSchemaTableNameso now the Connector will have access both to the actual schema/table name and also to the transformed one and it can decide accordingly. Here we have added support only forSelectqueries if this approach looks good then we can add support for the other kind of queries and will update the test suite for the same.