Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[native] Remove dependencies of old arbitrator config #23691

Merged
merged 1 commit into from
Sep 20, 2024
+5 −2
Merged

[native] Remove dependencies of old arbitrator config #23691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion presto-native-execution/presto_cpp/main/PrestoServer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -739,7 +739,7 @@ void PrestoServer::initializeThreadPools() {
#ifdef __linux__
threadFactory = std::make_shared<BatchThreadFactory>("Driver");
#else
VELOX_FAIL("Batch scheduling policy can only be enabled on Linux")
VELOX_FAIL("Batch scheduling policy can only be enabled on Linux");
#endif
} else {
threadFactory = std::make_shared<folly::NamedThreadFactory>("Driver");
Expand Down
5 changes: 4 additions & 1 deletion presto-native-execution/presto_cpp/main/tests/TaskManagerTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,10 @@ class TaskManagerTest : public testing::Test {
velox::memory::MemoryManagerOptions options;
options.allocatorCapacity = 8L << 30;
options.arbitratorCapacity = 6L << 30;
options.memoryPoolInitCapacity = 512 << 20;
options.extraArbitratorConfigs = {
{std::string(velox::memory::SharedArbitrator::ExtraConfig::
kMemoryPoolInitialCapacity),
"512MB"}};
options.arbitratorKind = "SHARED";
options.checkUsageLeak = true;
options.arbitrationStateCheckCb = memoryArbitrationStateCheck;
Expand Down
Loading