add a note in vscode section #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This node is regarding a fix introduced in prettier-vscode 3.8.0 around Nov 2019 causing vscode settings to be ignored.
mattiaerre
approved these changes
Jun 7, 2020
There was a problem hiding this comment.
thanks for this; it LGTM; what do you think @Janther and @fvictorio ?
README.md
Outdated
| } | ||
| ] | ||
| } | ||
| ``` |
There was a problem hiding this comment.
you may want to add a new line here; thanks 😊
|
I feel we could do this more concisely? The first paragraph added is great. After that, I think we can just say something like:
Since the linked page has everything a user should need. |
|
Yea, there were repetitions and I wished to change it into something but didn't know what. Thanks for the link, updating this right away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This node is regarding a fix introduced in prettier-vscode 3.8.0 around Nov 2019 causing vscode settings to be ignored (prettier/prettier-vscode#1079). Looks like many people around the world faced a trivial looking problem (prettier/prettier-vscode#1085).
Please let me know if any changes are required.