Make chain breaking as similar to original prettier (js) as much as possible

[eldair]

There is a hardcoded line which is the cause of chain breaks even though the expression would fit in one line. This is a quick and easy solution for #1545

I have adjusted test so they all pass but if this is merged than some of those could be removed as redundant.

[eldair]

I have updated the pull request to include a new option where user can define their own max calls in a chain before break occurs. The default option is left as is (I think the number 3 is based on similar option in main prettier repo) so it would not affect current codebases.

[czosel]

Hi @eldair, thanks for contributing! I think adding an option for this doesn't fit to the Prettier option philosophy. Did you already look into how Prettier for JS handles this? It would be awesome if we could solve it the same way.

[eldair]

Hi @czosel , I'm sorry, I didn't see that doc about adding options. The next best thing in my opinion is to remove chains limit and to leave them in single line if they can fit (they would still break in case of multiline closures). this would be as close to the js counterpart as possible without adding checks for call complexity which might not even be needed for php.

This is from prettier (js) with my comments

  // We don't want to print in one line if at least one of these conditions occurs:
  //  * the chain has comments, - this is taken care of
  //  * the chain is an expression statement and all the arguments are literal-like ("fluent configuration" pattern), - this one I don't understand (it has no separate check in the code)
  //  * the chain is longer than 2 calls and has non-trivial arguments or more than 2 arguments in any call but the first one, - in php arrow functions don't tend to be complicated and regular multiline functions would already break the chain
  //  * any group but the last one has a hard line, - taken care of
  //  * the last call's arguments have a hard line and other calls have non-trivial arguments. - same as 3.

[eldair]

Me again, I have started digging into isSimpleCallArgument of prettier. I will get back if I manage to port it for php to be on par with js version.

[eldair]

@czosel Pull request can be checked now. The code is not perfect and I tried to test as many combination as I could think of but it is much closer to the JS counterpart and I think better than the current implementation.
Let me know if something should be changed/fixed/improved.

[cseufert]

Change looks good to me, however, can you reformat with prettier and commit? See CI / Lint action, at least print.mjs needs reformating.

[eldair]

@cseufert thanks for checking it out, i've fixed the file

[czosel]

LGTM, thanks for the awesome contribution @eldair! 🎉

[czosel]

Released in v0.22.2 🎉

[eldair]

Woohoo 🎉