Code loss from transformation of symbol arrays

[mpoisot]

Metadata

• Ruby version: ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-darwin18]
• @prettier/plugin-ruby version: 0.12.2
  Installed in ~/.vscode/extensions/esbenp.prettier-vscode-1.9.0 as suggested here.

Input

Rails.application.config.middleware.insert_before 0, Rack::Cors do
  allow do
    origins 'localhost'

    resource '*',
      headers: :any,
      methods: [:get, :post, :put, :patch, :delete, :options, :head]
  end
end

test1 = methods: [:get, :post, :put, :patch, :delete, :options, :head]

test2 = { methods: [:get, :post, :put, :patch, :delete, :options, :head] }

Current output

Rails.application.config.middleware.insert_before 0, Rack::Cors do
  allow do
    origins 'localhost'

    resource '*',
             headers: :any, methods: %i[get post put patch delete options head]
  end
end

test1 = methods

Expected output

1. I don't expect test1 and test2 lines to lose a bunch of code.
2. I don't expect an array of symbols to change to %i[] format, and I can't find a way to turn it off. I see where the transformation happens, but I don't know the framework well enough to know how to disable it properly.

[kddnewton]

Hi @mpoisot -

1. The code you gave is invalid ruby. There's a bug in that prettier isn't telling you it's invalid, but it is. It's on the line with assignment to test1.
2. This is intentional. %i literal arrays are not a configuration option - they're meant to replace all arrays with just simple symbol literals.

[mpoisot]

Is there some background story behind converting to %i arrays? Is it superior somehow, or just a style consistency thing?

[kddnewton]

Pretty much all of the decisions in here are from the community ruby style guide. This one in particular is from https://github.com/rubocop-hq/ruby-style-guide/blob/master/README.md#percent-i

On Tue, May 14, 2019 at 9:25 PM marcel ***@***.***> wrote: Is there some background story behind converting to %i arrays? Is it superior somehow, or just a style consistency thing? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#304?email_source=notifications&email_token=ABG3P3XXA4DIJRWHZ6HI2GTPVNRCHA5CNFSM4HM5S422YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVNHWKY#issuecomment-492469035>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABG3P3UZJUI67M4E4KCGEJLPVNRCHANCNFSM4HM5S42Q> .

-- *Kevin D. Deisz* CTO, CultureHQ <https://www.culturehq.com>

[mpoisot]

Very helpful, thanks.

[kddnewton]

No worries! Thanks for trying the plugin!