feat(errors): do not display a popup for "undefined" error messages

These messages were very annoying because many plugins do not properly define these and it tends to
spam the user.

dist/executePrettier/handleError.js

@@ -27,6 +27,10 @@ const setErrorMessageInLinter = ({ editor, bufferRange, error }) => linter.setMe
 
 const isSyntaxError = _.overSome([_.flow(_.get('error.loc.start.line'), _.isInteger), _.flow(_.get('error.loc.line'), _.isInteger)]);
 
+const isUndefinedError = _.flow(_.get('error.message'),
+// $FlowIssue
+_.matches('undefined'));
+
 const isFilePathPresent = _.flow(_.get('editor'), getCurrentFilePath, _.negate(_.isNil));
 
 const displayErrorInPopup = args => console.error(args.error) || // eslint-disable-line no-console
@@ -35,6 +39,7 @@ addErrorNotification(`prettier-atom failed: ${args.error.message}`, {
   dismissable: true
 });
 
-const handleError = _.flow(_.cond([[_.overEvery([isSyntaxError, isFilePathPresent]), setErrorMessageInLinter], [_.stubTrue, displayErrorInPopup]]));
+const handleError = _.flow(_.cond([[_.overEvery([isSyntaxError, isFilePathPresent]), setErrorMessageInLinter], [isUndefinedError, args => console.error('Prettier encountered an error:', args.error)], // eslint-disable-line no-console
+[_.stubTrue, displayErrorInPopup]]));
 
 module.exports = handleError;

src/executePrettier/handleError.js

@@ -52,6 +52,12 @@ const isSyntaxError: HandleErrorArgs => boolean = _.overSome([
   ),
 ]);
 
+const isUndefinedError: HandleErrorArgs => boolean = _.flow(
+  _.get('error.message'),
+  // $FlowIssue
+  _.matches('undefined'),
+);
+
 const isFilePathPresent: HandleErrorArgs => boolean = _.flow(
   _.get('editor'),
   getCurrentFilePath,
@@ -68,6 +74,7 @@ const displayErrorInPopup = (args: HandleErrorArgs) =>
 const handleError: HandleErrorArgs => void = _.flow(
   _.cond([
     [_.overEvery([isSyntaxError, isFilePathPresent]), setErrorMessageInLinter],
+    [isUndefinedError, args => console.error('Prettier encountered an error:', args.error)], // eslint-disable-line no-console
     [_.stubTrue, displayErrorInPopup],
   ]),
 );

src/executePrettier/handleError.test.js

@@ -122,3 +122,14 @@ it('displays errors in a popup if there is no filepath (linter requires a filepa
   expect(addErrorNotification).toHaveBeenCalled();
   expect(console.error).toHaveBeenCalledWith(error); // eslint-disable-line no-console
 });
+
+it('only logs, but does not display "Undefined" errors', () => {
+  // plugins cause lots of these and they're too spammy
+  getCurrentFilePath.mockImplementation(() => null);
+  const error = new Error('undefined');
+
+  handleError({ error });
+
+  expect(addErrorNotification).not.toHaveBeenCalled();
+  expect(console.error).toHaveBeenCalledWith('Prettier encountered an error:', error); // eslint-disable-line no-console
+});