Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Ignored File is written #446

Closed
tbremer opened this issue Aug 22, 2018 · 2 comments · Fixed by #447
Closed

Ignored File is written #446

tbremer opened this issue Aug 22, 2018 · 2 comments · Fixed by #447
Labels
bug

Comments

@tbremer
Copy link

tbremer commented Aug 22, 2018 •
edited
Loading

I have a set of files ignored:

dist/
package.json
.babelrc

However, when saving the .babelrc file prettier is being run against it and the file is being modified.

prettier-0 55 1-babel

Running npx prettier .babelrc does not have this issue (npx prettier is running version 1.14.2 if that matters)

Output of the Prettier: Debug command:

Atom version: 1.29.0
prettier-atom version: 0.55.1
prettier: bundled
prettier version: 1.13.4
prettier-eslint version: 8.8.2
prettier-atom configuration: {
  "formatOnSaveOptions": {
    "isDisabledIfNoConfigFile": true,
    "isDisabledIfNotInPackageJson": true,
    "showInStatusBar": true,
    "enabled": false,
    "respectEslintignore": true,
    "excludedGlobs": [],
    "whitelistedGlobs": []
  },
  "useEslint": false,
  "useStylelint": false,
  "prettierEslintOptions": {
    "prettierLast": false
  }
}
@robwise
Copy link
Collaborator

robwise commented Aug 23, 2018

Confirmed, working on a fix now.

robwise added a commit that referenced this issue Aug 23, 2018
@robwise
fix(prettierignore): properly recognized that files are ignored
831a9f3 
#404 switched to deferring to Prettier's `resolveConfig` and `getFileInfo` functions for determining
whether a file is formattable. We were not correctly invoking the API for `getFileInfo` so every
file was coming up as not ignored.

Fixes #446
@robwise robwise mentioned this issue Aug 23, 2018
Merged
robwise added a commit that referenced this issue Aug 23, 2018
@robwise
fix(prettierignore): properly ignore files again
e5a524f 
whether a file is formattable. We were not correctly invoking the API for `getFileInfo` so every
file was coming up as not ignored.

Fixes #446
robwise added a commit that referenced this issue Aug 23, 2018
@robwise
fix(prettierignore): properly ignore files again
b5dd969 
whether a file is formattable. We were not correctly invoking the API for `getFileInfo` so every
file was coming up as not ignored.

Fixes #446
robwise added a commit that referenced this issue Aug 23, 2018
@robwise
fix(prettierignore): properly ignore files again
dd4c849 
PR #404 changed to using Prettier's `getFileInfo` and `resolveConfig` functions to determine
whether a file is formattable. We were not correctly invoking the API for `getFileInfo` so every
file was coming up as not ignored.

Fixes #446
@tbremer
Copy link
Author

tbremer commented Aug 23, 2018

Thanks for the expedient fix!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(prettierignore): properly ignore files again prettier/prettier-atom
2 participants
@tbremer @robwise