Add support for local instance plugins #817
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the status bar and edit provider logic to use the local Prettier instance when possible.
Refactor supported language resolution utils to use a provided file path to resolve a prettier instance instead of requiring all call sites to resolve instances individually.
Install `npm-run-all` and use it to run preparation steps for tests.
Closed
|
Yay! |
|
Is there anything to do to take this forward? Would be great if this could be merged soon 😄 |
|
prettier-vscode/src/PrettierEditProvider.ts Line 154 in 9ab2565 Editing this line fixes #878. { ...fileOptions, filepath: fileName }, |
Merged
|
Replaced by #899 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves upon the changes in #706 to always resolve the local prettier instance when resolving supported languages.
This allows format provider and status bar handler to be aware of locally-installed Prettier plugins.
This is an alternative implementation of #757, and should fix #395 and fix #612 as well.
CHANGELOG.mdwith a summary of your changes