[UXPT-4816] Add close button to banner #1363
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1363 +/- ##
==========================================
+ Coverage 94.71% 94.96% +0.24%
==========================================
Files 195 195
Lines 2309 2324 +15
Branches 411 416 +5
==========================================
+ Hits 2187 2207 +20
+ Misses 66 61 -5
Partials 56 56
☔ View full report in Codecov by Sentry. |
sdalonzo
reviewed
Jul 21, 2023
| const closeButton = container.querySelector('button') | ||
| expect(closeButton).toBeTruthy() | ||
| closeButton.click() | ||
| expect(spyOnClose).toBeCalled() |
sdalonzo
reviewed
Jul 21, 2023
| @@ -39,6 +40,47 @@ const CustomButton = styled(Button)` | |||
| text-decoration: ${(props) => (props.buttonTextUnderline ? 'underline' : 'none')}; | |||
| ` | |||
|
|
|||
| const BannerContent = styled(Box)` | |||
There was a problem hiding this comment.
@sdalonzo Using Box here should be more correct. Using Flex will make all the items occupy a whole line. It depends on the design.
Box
Flex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://priceline.atlassian.net/browse/UXPT-4816
Description
Add close button and onClose function to the GenericBanner
Image
