Merge pull request #12402 from mmorgan4x/focus-trap-fix

#12349 focus trap breaking on elements whose ancestors are hidden
primefaces · Dec 28, 2022 · 3d3aa78 · 3d3aa78
2 parents 178508e + 73fb9a1
commit 3d3aa78
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/app/components/dom/domhandler.ts b/src/app/components/dom/domhandler.ts
@@ -615,7 +615,7 @@ export class DomHandler {
 
         let visibleFocusableElements = [];
         for (let focusableElement of focusableElements) {
-            if (getComputedStyle(focusableElement).display != 'none' && getComputedStyle(focusableElement).visibility != 'hidden') visibleFocusableElements.push(focusableElement);
+            if (!!(focusableElement.offsetWidth || focusableElement.offsetHeight || focusableElement.getClientRects().length)) visibleFocusableElements.push(focusableElement);
         }
         return visibleFocusableElements;
     }