Merge pull request #12292 from primefaces/issue-12291

Fixed #12291 - Table | On col reorder the col destination position in…
primefaces · Nov 28, 2022 · 94944c6 · 94944c6
2 parents 223ab78 + a2cde03
commit 94944c6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 13 deletions.
diff --git a/src/app/components/table/table.css b/src/app/components/table/table.css
@@ -141,7 +141,6 @@
 .p-datatable-reorder-indicator-up,
 .p-datatable-reorder-indicator-down {
     position: absolute;
-    display: none;
 }
 
 .p-datatable-reorderablerow-handle {

diff --git a/src/app/components/table/table.ts b/src/app/components/table/table.ts
@@ -222,8 +222,8 @@ export class TableService {
             </div>
 
             <div #resizeHelper class="p-column-resizer-helper" style="display:none" *ngIf="resizableColumns"></div>
-            <span #reorderIndicatorUp class="pi pi-arrow-down p-datatable-reorder-indicator-up" style="display:none" *ngIf="reorderableColumns"></span>
-            <span #reorderIndicatorDown class="pi pi-arrow-up p-datatable-reorder-indicator-down" style="display:none" *ngIf="reorderableColumns"></span>
+            <span #reorderIndicatorUp class="pi pi-arrow-down p-datatable-reorder-indicator-up" style="display: none;" *ngIf="reorderableColumns"></span>
+            <span #reorderIndicatorDown class="pi pi-arrow-up p-datatable-reorder-indicator-down" style="display: none;" *ngIf="reorderableColumns"></span>
         </div>
     `,
     providers: [TableService],
@@ -2051,14 +2051,8 @@ export class Table implements OnInit, AfterViewInit, AfterContentInit, Blockable
                     this.reorderIndicatorDownViewChild.nativeElement.style.left = targetLeft - Math.ceil(this.reorderIconWidth / 2) + 'px';
                     this.dropPosition = -1;
                 }
-
-                if ((dropIndex - dragIndex === 1 && this.dropPosition === -1) || (dropIndex - dragIndex === -1 && this.dropPosition === 1)) {
-                    this.reorderIndicatorUpViewChild.nativeElement.style.display = 'none';
-                    this.reorderIndicatorDownViewChild.nativeElement.style.display = 'none';
-                } else {
-                    this.reorderIndicatorUpViewChild.nativeElement.style.display = 'block';
-                    this.reorderIndicatorDownViewChild.nativeElement.style.display = 'block';
-                }
+                this.reorderIndicatorUpViewChild.nativeElement.style.display = 'block';
+                this.reorderIndicatorDownViewChild.nativeElement.style.display = 'block';
             } else {
                 event.dataTransfer.dropEffect = 'none';
             }
@@ -2068,8 +2062,6 @@ export class Table implements OnInit, AfterViewInit, AfterContentInit, Blockable
     onColumnDragLeave(event) {
         if (this.reorderableColumns && this.draggedColumn) {
             event.preventDefault();
-            this.reorderIndicatorUpViewChild.nativeElement.style.display = 'none';
-            this.reorderIndicatorDownViewChild.nativeElement.style.display = 'none';
         }
     }