Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pButton Directive throws error when label is set when async pipe #10719

Closed
amcclellan opened this issue Oct 7, 2021 · 0 comments
Closed

pButton Directive throws error when label is set when async pipe #10719

amcclellan opened this issue Oct 7, 2021 · 0 comments
Assignees
@yigitfindikli
Labels
LTS-FIXED-10.1.4 Fixed in PrimeNG LTS 10.1.4 LTS-FIXED-11.4.7 Fixed in PrimeNG LTS 11.4.7 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
12.2.1

Comments

@amcclellan
Copy link

PrimeNG Version: 12.2.0

Issue: when setting a button label to an async pipe, for instance:
<button pButton type="button" label="{{ "ENTER" | translate }}" class="p-button-sm"></button>

you will get the error:
className is undefined"addMultipleClasses
@amcclellan amcclellan mentioned this issue Oct 7, 2021
Merged
@yigitfindikli yigitfindikli self-assigned this Oct 8, 2021
@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Oct 8, 2021
@yigitfindikli yigitfindikli added this to the 12.2.1 milestone Oct 8, 2021
yigitfindikli added a commit that referenced this issue Oct 8, 2021
@yigitfindikli
Merge pull request #10721 from amcclellan/10719
ae6cf6c 
Fixed #10719 - pButton Directive throws error when label is set when async pipe
@yigitfindikli yigitfindikli added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working LTS-PORTABLE and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Oct 8, 2021
yigitfindikli added a commit that referenced this issue Oct 8, 2021
@yigitfindikli
Refactor #10719
b11234b
@yigitfindikli yigitfindikli added LTS-FIXED-11.4.7 Fixed in PrimeNG LTS 11.4.7 LTS-FIXED-10.1.4 Fixed in PrimeNG LTS 10.1.4 and removed LTS-PORTABLE labels Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yigitfindikli yigitfindikli

Labels
LTS-FIXED-10.1.4 Fixed in PrimeNG LTS 10.1.4 LTS-FIXED-11.4.7 Fixed in PrimeNG LTS 11.4.7 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
12.2.1
Development

No branches or pull requests
2 participants
@amcclellan @yigitfindikli