Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

float-label chips problem #10725

Closed
MatteoTrapasso opened this issue Oct 8, 2021 · 2 comments
Closed

float-label chips problem #10725

MatteoTrapasso opened this issue Oct 8, 2021 · 2 comments
Assignees
Labels
LTS-FIXED-10.1.4 Fixed in PrimeNG LTS 10.1.4 LTS-FIXED-11.4.7 Fixed in PrimeNG LTS 11.4.7 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@MatteoTrapasso
Copy link
Contributor

MatteoTrapasso commented Oct 8, 2021

when we preload the input data for the component chips, the label doesn't move up.
This is due to the missing method ngAfterViewInit() in the component.
In this link we can show a simulation error on stackblitz. Please don't interact with the application to display the error.

https://primeng-inputtext-demo-gods8k.stackblitz.io/page

solution:
file chips.ts

` ngAfterContentInit() {
this.templates.forEach((item) => {
switch(item.getType()) {
case "item":
this.itemTemplate = item.template;
break;

            default:
                this.itemTemplate = item.template;
            break;
        }
    });
    this.updateFilledState()
}`
@MatteoTrapasso
Copy link
Contributor Author

considering that this is a problem found on multiple components that use FloatLabel, should you make changes on all components or find a common solution?

yigitfindikli added a commit that referenced this issue Oct 8, 2021
@yigitfindikli
Copy link
Contributor

Fixed in aff3b3b.

yigitfindikli added a commit that referenced this issue Oct 8, 2021
@yigitfindikli yigitfindikli self-assigned this Oct 8, 2021
@yigitfindikli yigitfindikli added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Oct 8, 2021
@yigitfindikli yigitfindikli added this to the 12.2.1 milestone Oct 8, 2021
yigitfindikli added a commit that referenced this issue Oct 14, 2021
@yigitfindikli yigitfindikli added LTS-FIXED-11.4.7 Fixed in PrimeNG LTS 11.4.7 LTS-FIXED-10.1.4 Fixed in PrimeNG LTS 10.1.4 and removed LTS-PORTABLE labels Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS-FIXED-10.1.4 Fixed in PrimeNG LTS 10.1.4 LTS-FIXED-11.4.7 Fixed in PrimeNG LTS 11.4.7 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants