Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngModel is not working properly on p-input number #10941

Closed
hamz4arif opened this issue Dec 9, 2021 · 4 comments
Closed

ngModel is not working properly on p-input number #10941

hamz4arif opened this issue Dec 9, 2021 · 4 comments
Labels
Status: Discussion Issue or pull request needs to be discussed by Core Team

Comments

@hamz4arif
Copy link

ngModel is not working properly in p-input number it updates the value on focus out not on every input like other controls

@yigitfindikli yigitfindikli added the Status: Discussion Issue or pull request needs to be discussed by Core Team label Dec 9, 2021
@waratah
Copy link
Contributor

waratah commented Jan 11, 2022

I have a directive that verifies minimums and maximums (min and max of inputNumber truncate which I believe is a bad user experience). This directive used to trigger on ngModel update after every keystroke so the maximum error appeared as soon as the value was exceeded. it now does it only on blur.

@waratah
Copy link
Contributor

waratah commented Jan 19, 2022

#11093

@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you reopen the issue so we can include it in our roadmap?
Please don't forget to add your feedback as a comment after reopening the issue. These will be taken into account by us and will contribute to the development of this feature. Thanks a lot for your understanding!

Best Regards,

@hmoreras
Copy link

this still an issue when using it with Model Driven Forms - formControlName the validation of the form only happens onBlur

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Discussion Issue or pull request needs to be discussed by Core Team
Projects
None yet
Development

No branches or pull requests

5 participants