Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 10941 - Keep the value for input number updating #11093

Closed
wants to merge 5 commits into from
Closed

🐛 10941 - Keep the value for input number updating #11093

wants to merge 5 commits into from

Conversation

waratah
Copy link
Contributor

@waratah waratah commented Jan 19, 2022

###Defect Fixes

10941

@waratah waratah mentioned this pull request Jan 19, 2022
Closed
@waratah waratah mentioned this pull request Feb 8, 2022
Closed
@github-actions github-actions bot added the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Sep 13, 2022
@cetincakiroglu cetincakiroglu linked an issue Nov 22, 2022 that may be closed by this pull request
Component: InputNumber - InputNumber is not dirty when value changes - not work with ReactiveForms #12268
Closed
@cetincakiroglu cetincakiroglu added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Nov 22, 2022
cetincakiroglu
cetincakiroglu requested changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@cetincakiroglu cetincakiroglu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, what's the purpose of the changes in tabview.css, also could you please resolve conflicts?

src/app/components/tabview/tabview.css Outdated Show resolved Hide resolved
@cetincakiroglu
Copy link
Contributor

Hi,
could you please resolve conflicts so I can merge safely?

@Jonesmann1337 Jonesmann1337 mentioned this pull request Mar 7, 2023
Open
@mertsincan
Copy link
Member

Hi,

Sorry for the delayed response! Unfortunately, your PR is out of date. So it's closed. Can you create a new PR for us? I will merge it as soon as possible.

Best Regards,

@mertsincan mertsincan closed this Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cetincakiroglu cetincakiroglu cetincakiroglu approved these changes

Assignees
No one assigned
Labels
Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Component: InputNumber - InputNumber is not dirty when value changes - not work with ReactiveForms
3 participants
@waratah @cetincakiroglu @mertsincan