Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar firstDayOfWeek returns the number of months #11070

Closed
lco-dev opened this issue Jan 13, 2022 · 1 comment
Closed

Calendar firstDayOfWeek returns the number of months #11070

lco-dev opened this issue Jan 13, 2022 · 1 comment
Assignees
@yigitfindikli
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
13.1.0

Comments

@lco-dev
Copy link
Contributor

lco-dev commented Jan 13, 2022

I'm submitting a ...

[x ] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
firstDayOfWeek in a Calendar component returns the number of months.

Expected behavior
firstDayOfWeek in a Calendar component should return the first day of week.

Minimal reproduction of the problem with instructions

  • create a Calendar component
  • access the firstDayOfWeek property

What is the motivation / use case for changing the behavior?
Noticed this by chance, while reviewing the changes from 9c6682c.
Seems to be a copy/paste issue while creating the getter (related to #9635).

  • Angular version: 13.x

  • PrimeNG version: 13.0.4
lco-dev added a commit to lco-dev/primeng that referenced this issue Jan 13, 2022
@lco-dev
Merge pull request #1 from lco-dev/calendar_firstDayOfWeek_regression
e51c72e 
Fixes primefaces#11070 - Regression on Calendar's firstDayOfWeek getter
@lco-dev
Copy link
Contributor Author

lco-dev commented Jan 13, 2022

Proposed PR #11071 to fix this.

@yigitfindikli yigitfindikli self-assigned this Jan 14, 2022
@yigitfindikli yigitfindikli added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Jan 14, 2022
@yigitfindikli yigitfindikli added this to the 13.0.5 milestone Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yigitfindikli yigitfindikli

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
13.1.0
Development

No branches or pull requests
2 participants
@yigitfindikli @lco-dev