Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toast | z-index shouldn't removed when other toasts are shown #11313

Closed
Urtgard opened this issue Mar 17, 2022 · 0 comments · Fixed by #11314
Closed

Toast | z-index shouldn't removed when other toasts are shown #11313

Urtgard opened this issue Mar 17, 2022 · 0 comments · Fixed by #11314
Assignees
@yigitfindikli @cetincakiroglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
13.3.2

Comments

@Urtgard
Copy link
Contributor

Urtgard commented Mar 17, 2022 •
edited
Loading

Prime 13.3

When a toast is hidden the container's z-index will be removed. Therefore other toasts in the same container are now covered by other elements.

Can be observed on the toast example page: https://www.primefaces.org/primeng/#/toast

1toast
2toast
Urtgard added a commit to Urtgard/primeng that referenced this issue Mar 17, 2022
@Urtgard
Fixed primefaces#11313 - Toast | z-index shouldn't removed when other…
2bbdf69 
… toasts are shown
@Urtgard Urtgard mentioned this issue Mar 17, 2022
Merged
@cetincakiroglu cetincakiroglu self-assigned this Mar 18, 2022
@cetincakiroglu cetincakiroglu added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Mar 18, 2022
@cetincakiroglu cetincakiroglu added this to the 13.Future milestone Mar 18, 2022
@cetincakiroglu cetincakiroglu linked a pull request Mar 18, 2022 that will close this issue
Fixed #11313 - Toast | z-index shouldn't removed when other toasts are shown #11314
Merged
@cetincakiroglu cetincakiroglu modified the milestones: 13.Future, 13.3.2 Mar 29, 2022
yigitfindikli added a commit that referenced this issue Mar 30, 2022
@yigitfindikli
Merge pull request #11314 from Urtgard/master
232b402 
Fixed #11313 - Toast | z-index shouldn't removed when other toasts are shown
@yigitfindikli yigitfindikli added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Mar 30, 2022
yigitfindikli added a commit that referenced this issue Mar 30, 2022
@yigitfindikli
Refactor #11313
828f63a
@yigitfindikli yigitfindikli self-assigned this Mar 30, 2022
@tugcekucukoglu tugcekucukoglu mentioned this issue Apr 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yigitfindikli yigitfindikli

@cetincakiroglu cetincakiroglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
13.3.2
Development

Successfully merging a pull request may close this issue.

Fixed #11313 - Toast | z-index shouldn't removed when other toasts are shown Urtgard/primeng
3 participants
@Urtgard @yigitfindikli @cetincakiroglu