Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: InputNumber - InputNumber is not dirty when value changes - not work with ReactiveForms #12268

Closed
yhoangaleano opened this issue Nov 22, 2022 · 2 comments

Comments

@yhoangaleano
Copy link

yhoangaleano commented Nov 22, 2022

Describe the bug

When working with the p-inputNumber and reactive forms, listening for field value changes does not work. It only executes the change when the field is exited and executes the blur event. I cite the issue that had already been opened and never was given solution, in fact this person left the solution in the following link https://github.com/primefaces/primeng/pull/11093/files in line 850.

#10902

Environment

Angular version: 15.0.0

PrimeNG version: 14.2.2

Reproducer

https://stackblitz.com/edit/primeng-inputnumber-demo-hjxey9?file=src%2Fapp%2Fapp.component.ts,src%2Fapp%2Fapp.component.html

Angular version

15.0.0

PrimeNG version

14.2.2

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

16

Browser(s)

Chrome Version 107.0.5304.68 (Official Build) (64-bit)

Steps to reproduce the behavior

Type a different value in the primeNg number input -> The form does not become dirty.
However, typing in the normal text input -> The form becomes dirty.

Expected behavior

No response

@yhoangaleano yhoangaleano added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 22, 2022
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 22, 2022
@cetincakiroglu cetincakiroglu added this to the 15.0.0 milestone Nov 22, 2022
@yhoangaleano
Copy link
Author

Thanks ♥

@cetincakiroglu cetincakiroglu modified the milestones: 15.0.0, 15.Future Dec 12, 2022
@cetincakiroglu cetincakiroglu modified the milestones: 15.Future, 15.1.2 Jan 26, 2023
@cetincakiroglu cetincakiroglu added Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Jan 27, 2023
@cetincakiroglu cetincakiroglu modified the milestones: 15.2.0, 15.Future, 15.2.1 Jan 30, 2023
@cetincakiroglu
Copy link
Contributor

Hi,

Continuation of the issue at #12733 and it's fixed.
Closing the issue, thanks for reporting!

@cetincakiroglu cetincakiroglu removed Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. labels Mar 15, 2023
@cetincakiroglu cetincakiroglu removed this from the 15.2.1 milestone Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants