Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pFocusTrap: ignoring anchor tags as focusable elements #12527

Closed
mmorgan4x opened this issue Jan 19, 2023 · 0 comments · Fixed by #12530
Closed

pFocusTrap: ignoring anchor tags as focusable elements #12527

mmorgan4x opened this issue Jan 19, 2023 · 0 comments · Fixed by #12530
Assignees
@mmorgan4x
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
15.2.0

Comments

@mmorgan4x
Copy link
Contributor

Describe the bug

Anchor tags within pFocusTrap are ignored when tabbing through focusable elements.

Environment

Chrome browser on Windows 10

Reproducer

https://stackblitz.com/edit/github-x5ff8g?file=src%2Fapp%2Fapp.component.html

Angular version

14.0.7

PrimeNG version

14.0.2

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

n/a

Browser(s)

chrome

Steps to reproduce the behavior

Create a pFocustrap element with an anchor tag inside. Give the anchor an href attribute. Notice it can't be focused.

Expected behavior

Anchor should be able to focus by tabbing.
@mmorgan4x mmorgan4x added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 19, 2023
@mmorgan4x mmorgan4x mentioned this issue Jan 19, 2023
Merged
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 26, 2023
cetincakiroglu added a commit that referenced this issue Jan 26, 2023
@cetincakiroglu
Merge pull request #12530 from mmorgan4x/focus-trap-anchor-fix
addafba 
fixed: issue where focustrap was skipping over anchor tags when tabbing #12527
@cetincakiroglu cetincakiroglu added this to the 15.1.2 milestone Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmorgan4x mmorgan4x

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
15.2.0
Development

Successfully merging a pull request may close this issue.

fixed: issue where focustrap was skipping over anchor tags when tabbing #12527 mmorgan4x/primeng
2 participants
@mmorgan4x @cetincakiroglu