Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar: onHide ist emitted twice #12564

Closed
m11t opened this issue Jan 27, 2023 · 0 comments · Fixed by #12566
Closed

Sidebar: onHide ist emitted twice #12564

m11t opened this issue Jan 27, 2023 · 0 comments · Fixed by #12566
Assignees
@cetincakiroglu
Labels
LTS-FIXED-14.2.4 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
15.2.0

Comments

@m11t
Copy link

m11t commented Jan 27, 2023

Describe the bug

When closing a sidebar the onHide EventEmitter is emitted twice:

  1. Through the close function call
  2. Through the onAnimationEnd function

Environment

Reproducer

https://github-2usv44.stackblitz.io

Angular version

at least since 13

PrimeNG version

at least since 13.0.4

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

11.0.4

Browser(s)

No response

Steps to reproduce the behavior

  1. Click on the button with the arrow
  2. Close the sidebar by either clicking on on the background mask or the close button (x)

Expected behavior

The onHide should only be emitted once.
@m11t m11t added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 27, 2023
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 27, 2023
@cetincakiroglu cetincakiroglu self-assigned this Jan 27, 2023
@cetincakiroglu cetincakiroglu added this to the 15.2.0 milestone Jan 27, 2023
cetincakiroglu added a commit that referenced this issue Jan 27, 2023
@cetincakiroglu
Fixed #12564 - Sidebar: onHide ist emitted twice
dc84d1e
@cetincakiroglu cetincakiroglu mentioned this issue Jan 27, 2023
Merged
cetincakiroglu added a commit that referenced this issue Jan 27, 2023
@cetincakiroglu
Merge pull request #12566 from primefaces/issue-12564
da81756 
Fixed #12564 - Sidebar: onHide ist emitted twice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cetincakiroglu cetincakiroglu

Labels
LTS-FIXED-14.2.4 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
15.2.0
Development

Successfully merging a pull request may close this issue.

Fixed #12564 - Sidebar: onHide ist emitted twice primefaces/primeng
3 participants
@m11t @gucal @cetincakiroglu