Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chips doesnt support RegExp Separator as per documentation #12640

Closed
olegkap opened this issue Feb 16, 2023 · 0 comments · Fixed by #12651
Closed

Chips doesnt support RegExp Separator as per documentation #12640

olegkap opened this issue Feb 16, 2023 · 0 comments · Fixed by #12651
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
16.3.0

Comments

@olegkap
Copy link

olegkap commented Feb 16, 2023

Describe the bug

An example for using Chips shows usage of RegEx for separator but documentation only shows that string is supported.

image

Is it possible to add regex support or perhaps to remove it from example since it is confusing?

Thanks,
Oleg

Environment

any

Reproducer

No response

Angular version

15.1.2

PrimeNG version

15.2.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.12.1

Browser(s)

any

Steps to reproduce the behavior

No response

Expected behavior

No response
@olegkap olegkap added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 16, 2023
volvachev added a commit to volvachev/primeng that referenced this issue Feb 19, 2023
@volvachev
fix(primeng/p-chips): docs and type of property separator
d1d674a 
Fixes primefaces#12640.
@volvachev volvachev mentioned this issue Feb 19, 2023
Merged
@ccremer ccremer mentioned this issue Apr 12, 2023
Merged
3 tasks
volvachev added a commit to volvachev/primeng that referenced this issue May 23, 2023
@volvachev
fix(primeng/p-chips): docs and type of property separator
36a3c0e 
Fixes primefaces#12640.
volvachev added a commit to volvachev/primeng that referenced this issue Jun 12, 2023
@volvachev
fix(primeng/p-chips): docs and type of property separator
820ee7d 
Fixes primefaces#12640.
@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 21, 2023
@mertsincan mertsincan added this to the 16.2.1 milestone Aug 21, 2023
mertsincan pushed a commit that referenced this issue Aug 21, 2023
@volvachev
fix(primeng/p-chips): docs and type of property separator (#12651)
3ae5bbe 
Fixes #12640.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
16.3.0
Development

Successfully merging a pull request may close this issue.

fix(primeng/p-chips): docs and type of property separator volvachev/primeng
2 participants
@mertsincan @olegkap