Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avatar and Badge use the same size attribute, add badgeSize property for badge #12959

Closed
ProfEibe opened this issue Apr 26, 2023 · 1 comment · Fixed by #12739
Closed

Avatar and Badge use the same size attribute, add badgeSize property for badge #12959

ProfEibe opened this issue Apr 26, 2023 · 1 comment · Fixed by #12739
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone
17.14.0

Comments

@ProfEibe
Copy link

Describe the bug

When using the Avatar-Component together with its Badge-Directive they use the same size attribute.
Setting the Avatars size to xlarge also enlarges its Badge.

Environment

Angular & PrimeNG 15

Reproducer

https://primeng.org/avatar#icon

Angular version

15

PrimeNG version

15

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18

Browser(s)

No response

Steps to reproduce the behavior

<p-avatar icon="pi pi-user" pBadge value="4" severity="success" styleClass="mr-2" size="large"></p-avatar>

Expected behavior

It should be possible to resize one without the other.
@ProfEibe ProfEibe added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 26, 2023
volvachev added a commit to volvachev/primeng that referenced this issue Apr 26, 2023
@volvachev
feat(primeng/p-badge): rework dynamic property rerender for directive
0356fca 
Fixes primefaces#12736.
Fixes primefaces#12959.
@volvachev volvachev mentioned this issue Apr 26, 2023
Merged
volvachev added a commit to volvachev/primeng that referenced this issue Apr 26, 2023
@volvachev
feat(primeng/p-badge): rework dynamic property rerender for directive
0abff48 
Fixes primefaces#12736.
Fixes primefaces#12959.
@ProfEibe
Copy link
Author

Can we have this pullrequest #12739 rather sooner than later. Would fix some problems that came up with the latest updates.

volvachev added a commit to volvachev/primeng that referenced this issue May 23, 2023
@volvachev
feat(primeng/p-badge): rework dynamic property rerender for directive
71bc3af 
Fixes primefaces#12736.
Fixes primefaces#12959.
volvachev added a commit to volvachev/primeng that referenced this issue May 23, 2023
@volvachev
feat(primeng/p-badge): rework dynamic property rerender for directive
a1311b0 
Fixes primefaces#12736.
Fixes primefaces#12959.
volvachev added a commit to volvachev/primeng that referenced this issue Jun 12, 2023
@volvachev
feat(primeng/p-badge): rework dynamic property rerender for directive
96d42ce 
Fixes primefaces#12736.
Fixes primefaces#12959.
@cetincakiroglu cetincakiroglu added this to the 17.15.0 milestone Apr 18, 2024
@cetincakiroglu cetincakiroglu mentioned this issue Apr 19, 2024
Closed
@cetincakiroglu cetincakiroglu modified the milestones: 17.15.0, 17.14.0 Apr 19, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 19, 2024
@cetincakiroglu cetincakiroglu changed the title Avatar and Badge use the same size attribute Avatar and Badge use the same size attribute, add badgeSize property for badge Apr 19, 2024
@cetincakiroglu cetincakiroglu added Type: New Feature Issue contains a new feature or new component request and removed Type: New Feature Issue contains a new feature or new component request Type: Bug Issue contains a bug related to a specific component. Something about the component is not working labels Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Milestone
17.14.0
Development

Successfully merging a pull request may close this issue.

feat(primeng/p-badge): rework dynamic property rerender for directive volvachev/primeng
2 participants
@ProfEibe @cetincakiroglu