Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong type definition of KeyFilter.pKeyFilter (pattern) #13086

Closed
Menecats opened this issue May 24, 2023 · 0 comments
Closed

Wrong type definition of KeyFilter.pKeyFilter (pattern) #13086

Menecats opened this issue May 24, 2023 · 0 comments
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
16.3.0

Comments

@Menecats
Copy link
Contributor

Describe the bug

The pKeyFilter directive currently accepts only a string as pattern (aliased to pKeyFilter).
This is misleading and should also match a RegExp.

Environment

.

Reproducer

No response

Angular version

16.0.2

PrimeNG version

16.0.0-rc.2

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.14.1

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@Menecats Menecats added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 24, 2023
Menecats added a commit to Menecats/primeng that referenced this issue May 24, 2023
@Menecats
Fix primefaces#13086 - KeyFilter.pattern type
2e12a6c
@Menecats Menecats mentioned this issue May 24, 2023
Merged
@cetincakiroglu cetincakiroglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jul 26, 2023
@cetincakiroglu cetincakiroglu modified the milestones: 16.1.0, 16.Future Jul 26, 2023
@mertsincan mertsincan modified the milestones: 16.Future, 16.2.1 Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
16.3.0
Development

No branches or pull requests
3 participants
@mertsincan @Menecats @cetincakiroglu